Re: [PR] refactor(google-cloud-logging): unify google-cloud-oauth.lua file [apisix]

Wed, 25 Sep 2024 01:07:51 -0700 


HuanXin-Chen commented on code in PR #11596:
URL: https://github.com/apache/apisix/pull/11596#discussion_r1774764641


##########
apisix/plugins/google-cloud-logging.lua:
##########
@@ -43,7 +43,7 @@ local schema = {
                     default = "https://oauth2.googleapis.com/token";
                 },
                 -- 
https://developers.google.com/identity/protocols/oauth2/scopes#logging
-                scopes = {
+                scope = {

Review Comment:
   According to OAuth2/OIDC rules, scope should not be used in the plural.
   
![image](https://github.com/user-attachments/assets/01ceef0b-745f-4848-b789-51028cbb0a59)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to