moonming commented on code in PR #11597:
URL: https://github.com/apache/apisix/pull/11597#discussion_r1776669401
##########
t/fips/jwt-auth.t:
##########
@@ -150,7 +117,7 @@ JWT token invalid: invalid jwt string
-=== TEST 5: add consumer with username and plugins with public_key,
private_key(private_key numbits = 1024)
+=== TEST 4: add consumer with username and plugins with public_key
Review Comment:
the same as test 1?
##########
t/fips/jwt-auth.t:
##########
@@ -122,21 +95,15 @@ passed
-=== TEST 4: sign/verify use RS256 algorithm(private_key numbits = 512)
+=== TEST 3: sign/verify use RS256 algorithm(private_key numbits = 512)
Review Comment:
why we need this test case?
##########
apisix/plugins/jwt-auth.lua:
##########
@@ -90,17 +88,16 @@ local consumer_schema = {
{
properties = {
public_key = {type = "string"},
- private_key= {type = "string"},
algorithm = {
enum = {"RS256", "ES256"},
},
},
- required = {"public_key", "private_key"},
+ required = {"public_key"},
Review Comment:
no test case for it
##########
t/fips/jwt-auth.t:
##########
Review Comment:
I don't understand this test file
##########
t/fips/jwt-auth.t:
##########
@@ -180,7 +145,7 @@ passed
-=== TEST 6: JWT sign and verify use RS256 algorithm(private_key numbits = 1024)
+=== TEST 5: JWT sign and verify use RS256 algorithm
Review Comment:
?
##########
t/perf/test_http.py:
##########
Review Comment:
why change this file? I think you can remove the perf CI
##########
t/plugin/jwt-auth.t:
##########
Review Comment:
there are many `private_key` in this test file, I don't know why we need it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
