shreemaan-abhishek opened a new pull request, #11775:
URL: https://github.com/apache/apisix/pull/11775

   ### Description
   
   When using auth plugins with the multi auth plugin, if one of the 
authentication fails but other auth plugins succeed, the basic auth plugin will 
record a warning log, causing inconvenience to the user.
   
   [apisix/apisix/plugins/multi-auth.lua at master ยท 
apache/apisix](https://github.com/apache/apisix/blob/master/apisix/plugins/multi-auth.lua#L75)
 The muti auth plugin does not record the error message returned by the plugin.
   
   ### Solution:
   When there are multiple plugins in muti auth, if the final verification is 
passed (that is, any plugin is verified), even if other plugins return errors, 
no error log needs to be recorded
   If all plugins fail to verify, summarize the error messages of multiple 
plugins into a log for recording.
   
   ### Checklist
   
   - [x] I have explained the need for this PR and the problem it solves
   - [x] I have explained the changes or the new features added to this PR
   - [x] I have added tests corresponding to this change
   - [ ] I have updated the documentation to reflect this change
   - [ ] I have verified that this change is backward compatible (If not, 
please discuss on the [APISIX mailing 
list](https://github.com/apache/apisix/tree/master#community) first)
   
   <!--
   
   Note
   
   1. Mark the PR as draft until it's ready to be reviewed.
   2. Always add/update tests for any changes unless you have a good reason.
   3. Always update the documentation to reflect the changes made in the PR.
   4. Make a new commit to resolve conversations instead of `push -f`.
   5. To resolve merge conflicts, merge master instead of rebasing.
   6. Use "request review" to notify the reviewer after making changes.
   7. Only a reviewer can mark a conversation as resolved.
   
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to