This is an automated email from the ASF dual-hosted git repository.
shreemaanabhishek pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 9f8031114 fix: allow special characters in uri params (#11788)
9f8031114 is described below
commit 9f8031114c15b7cccd1bf126d87c19f299cbf6d3
Author: Shreemaan Abhishek <[email protected]>
AuthorDate: Fri Nov 29 14:05:07 2024 +0545
fix: allow special characters in uri params (#11788)
---
apisix-master-0.rockspec | 2 +-
t/router/radixtree-uri-with-parameter2.t | 108 +++++++++++++++++++++++++++++++
2 files changed, 109 insertions(+), 1 deletion(-)
diff --git a/apisix-master-0.rockspec b/apisix-master-0.rockspec
index 9b9637f7c..5d6c6dafd 100644
--- a/apisix-master-0.rockspec
+++ b/apisix-master-0.rockspec
@@ -47,7 +47,7 @@ dependencies = {
"lua-resty-cookie = 0.2.0-1",
"lua-resty-session = 3.10",
"opentracing-openresty = 0.1",
- "lua-resty-radixtree = 2.9.1",
+ "lua-resty-radixtree = 2.9.2",
"lua-protobuf = 0.5.2-1",
"lua-resty-openidc = 1.7.6-3",
"luafilesystem = 1.7.0-2",
diff --git a/t/router/radixtree-uri-with-parameter2.t
b/t/router/radixtree-uri-with-parameter2.t
new file mode 100644
index 000000000..8659a8bc0
--- /dev/null
+++ b/t/router/radixtree-uri-with-parameter2.t
@@ -0,0 +1,108 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+use t::APISIX 'no_plan';
+
+repeat_each(1);
+log_level('info');
+worker_connections(256);
+no_root_location();
+no_shuffle();
+
+our $yaml_config = <<_EOC_;
+apisix:
+ node_listen: 1984
+ router:
+ http: 'radixtree_uri_with_parameter'
+_EOC_
+
+add_block_preprocessor(sub {
+ my ($block) = @_;
+
+ if (!$block->yaml_config) {
+ $block->set_value("yaml_config", $yaml_config);
+ }
+});
+
+run_tests();
+
+__DATA__
+
+=== TEST 1: set route with :name as a uri parameter
+--- config
+ location /t {
+ content_by_lua_block {
+ local t = require("lib.test_admin").test
+ local code, body = t('/apisix/admin/routes/1',
+ ngx.HTTP_PUT,
+ [[{
+ "upstream": {
+ "nodes": {
+ "127.0.0.1:1980": 1
+ },
+ "type": "roundrobin"
+ },
+ "plugins": {
+ "proxy-rewrite":{"uri":"/hello"}
+ },
+ "uri": "/name/:name/bar"
+ }]],
+ [[{
+ "value": {
+ "uri": "/name/:name/bar",
+ "upstream": {
+ "nodes": {
+ "127.0.0.1:1980": 1
+ },
+ "type": "roundrobin"
+ },
+ "plugins": {
+ "proxy-rewrite":{"uri":"/hello"}
+ },
+ },
+ "key": "/apisix/routes/1"
+ }]]
+ )
+
+ if code >= 300 then
+ ngx.status = code
+ end
+ ngx.say(body)
+ }
+ }
+--- request
+GET /t
+--- response_body
+passed
+
+
+
+=== TEST 2: parameters with special characters should pass
+--- request
+GET /name/with%20space/bar
+--- error_code: 200
+--- response_body
+hello world
+
+
+
+=== TEST 3: failing case for the above test
+--- request
+GET /name/with%20space/foo
+--- error_code: 404
+--- response_body
+{"error_msg":"404 Route Not Found"}
