bzp2010 commented on code in PR #793:
URL: https://github.com/apache/apisix-helm-chart/pull/793#discussion_r1895308680
##########
charts/apisix/values.yaml:
##########
@@ -448,6 +448,9 @@ apisix:
# - name: bar
# size: 1m
+ # Set the size of prometheus-metrics shared dict
+ prometheusSharedDictSize: 15m
Review Comment:
🤔 Is it a good idea to use a separate orphaned key?
Wouldn't it be better to implement it as a map and allow the original shared
dict name used by APISIX to be passed in directly for overriding. e.g.
```yaml
luaSharedDicts:
- name: prometheus-metrics
size: 100m
```
If you think this is unclear, perhaps it could also be called
`builtinLuaSharedDicts`. Or, make it configurable by `customLuaSharedDicts`,
although not intuitive.
BTW, if you update the values template, please update the documentation
along with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
