membphis commented on code in PR #11840:
URL: https://github.com/apache/apisix/pull/11840#discussion_r1896528782
##########
apisix/consumer.lua:
##########
@@ -101,10 +104,19 @@ local function plugin_consumer()
if not plugins[name] then
plugins[name] = {
nodes = {},
+ len = 0,
conf_version = consumers.conf_version
}
end
+ local cached_consumer = consumers_id_cache[val.value.id]
+ if cached_consumer and
+ cached_consumer.modifiedIndex == val.modifiedIndex then
+ plugins[name].len = plugins[name].len + 1
+ core.table.insert(plugins[name].nodes, plugins[name].len,
+ cached_consumer)
+ goto CONTINUE_INTERNAL
Review Comment:
shorter is better
```suggestion
goto CONTINUE
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
