kayx23 commented on code in PR #11910:
URL: https://github.com/apache/apisix/pull/11910#discussion_r1972898694


##########
docs/en/latest/plugins/proxy-cache.md:
##########
@@ -25,64 +26,66 @@ description: This document contains information about the 
Apache APISIX proxy-ca
 #
 -->
 
+<head>
+  <link rel="canonical" href="https://docs.api7.ai/hub/proxy-cache"; />
+</head>
+
 ## Description
 
-The `proxy-cache` Plugin can be used to cache the response from the Upstream. 
It can be used with other Plugins and currently supports disk-based and 
memory-based caching.
+The `proxy-cache` Plugin provides the capability to cache responses based on a 
cache key. The Plugin supports both disk-based and memory-based caching options 
to cache for [GET](https://anything.org/learn/serving-over-http/#get-request), 
[POST](https://anything.org/learn/serving-over-http/#post-request), and 
[HEAD](https://developer.mozilla.org/en-US/docs/Web/HTTP/Methods/HEAD) requests.
 
-The data to be cached can be filtered with response codes, request modes, or 
more complex methods using the `no_cache` and `cache_bypass` attributes.
+Responses can be conditionally cached based on request HTTP methods, response 
status codes, request header values, and more.
 
 ## Attributes
 
 | Name               | Type           | Required | Default                   | 
Valid values            | Description                                           
                                                                                
                                                                                
                                                                                
|
 
|--------------------|----------------|----------|---------------------------|-------------------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
-| cache_strategy     | string         | False    | disk                      | 
["disk","memory"]       | Specifies where the cached data should be stored.     
                                                                                
                                                                                
                                                                                
|
-| cache_zone         | string         | False    | disk_cache_one            | 
                        | Specifies which cache area to use. Each cache area 
can be configured with different paths. Cache areas can be predefined in your 
configuration file (`conf/config.yaml`). If the specified cache area is 
inconsistent with the pre-defined cache area in your configuration file, the 
cache is invalid. |
-| cache_key          | array[string]  | False    | ["$host", "$request_uri"] | 
                        | Key to use for caching. For example, `["$host", 
"$uri", "-cache-id"]`.                                                          
                                                                                
                                                                                
      |
-| cache_bypass       | array[string]  | False    |                           | 
                        | Conditions in which response from cache is bypassed. 
Whether to skip cache retrieval. If at least one value of the string parameters 
is not empty and is not equal to `0` then the response will not be taken from 
the cache. For example, `["$arg_bypass"]`.                                      
   |
-| cache_method       | array[string]  | False    | ["GET", "HEAD"]           | 
["GET", "POST", "HEAD"] | Request methods for which the response will be 
cached.                                                                         
                                                                                
                                                                                
       |
-| cache_http_status  | array[integer] | False    | [200, 301, 404]           | 
[200, 599]              | HTTP status codes of the Upstream response for which 
the response will be cached.                                                    
                                                                                
                                                                                
 |
-| hide_cache_headers | boolean        | False    | false                     | 
                        | When set to `true`, hide the `Expires` and 
`Cache-Control` response headers.                                               
                                                                                
                                                                                
|
-| cache_control      | boolean        | False    | false                     | 
                        | When set to `true`, complies with Cache-Control 
behavior in the HTTP specification. Used only for memory strategy.              
                                                                                
                                                                                
        |
-| no_cache           | array[string]  | False    |                           | 
                        | Conditions in which the response will not be cached. 
If at least one value of the string parameters is not empty and is not equal to 
`0` then the response will not be saved.                                        
                                                                                
 |
-| cache_ttl          | integer        | False    | 300 seconds               | 
                        | Time that a response is cached until it is deleted or 
refreshed. Comes in to effect when the `cache_control` attribute is not enabled 
or the proxied server does not return cache header. Used only for memory 
strategy.                                                                       
       |
+| cache_strategy     | string         | False    | disk                      | 
["disk","memory"]       | Caching strategy. Cache on disk or in memory.         
 |
+| cache_zone         | string         | False    | disk_cache_one            | 
                        | Cache zone used with the caching strategy. The value 
should match one of the cache zones defined in the [configuration 
files](#static-configurations) and should correspond to the caching strategy. 
For example, when using the in-memory caching strategy, you should use an 
in-memory cache zone. |
+| cache_key          | array[string]  | False    | ["$host", "$request_uri"] | 
                        | Key to use for caching. Support [Nginx 
variables](https://nginx.org/en/docs/varindex.html) and constant strings in 
values. Variables should be prefixed with a `$` sign.    |
+| cache_bypass       | array[string]  | False    |                           | 
                        | One or more parameters to parse value from, such that 
if any of the values is not empty and is not equal to `0`, response will not be 
retrieved from cache. Support [Nginx 
variables](https://nginx.org/en/docs/varindex.html) and constant strings in 
values. Variables should be prefixed with a `$` sign.     |
+| cache_method       | array[string]  | False    | ["GET", "HEAD"]           | 
["GET", "POST", "HEAD"] | Request methods of which the response should be 
cached.       |
+| cache_http_status  | array[integer] | False    | [200, 301, 404]           | 
[200, 599]              | Response HTTP status codes of which the response 
should be cached.   |
+| hide_cache_headers | boolean        | False    | false                     | 
                        | If true, hide `Expires` and `Cache-Control` response 
headers.   |
+| cache_control      | boolean        | False    | false                     | 
                        | If true, comply with `Cache-Control` behavior in the 
HTTP specification. Only valid for in-memory strategy.     |
+| no_cache           | array[string]  | False    |                           | 
                        | One or more parameters to parse value from, such that 
if any of the values is not empty and is not equal to `0`, response will not be 
cached. Support [Nginx variables](https://nginx.org/en/docs/varindex.html) and 
constant strings in values. Variables should be prefixed with a `$` sign.       
|
+| cache_ttl          | integer        | False    | 300          |        >=1   
       | Cache time to live (TTL) in seconds when caching in memory. To adjust 
the TTL when caching on disk, update `cache_ttl` in the [configuration 
files](#static-configurations). The TTL value is evaluated in conjunction with 
the values in the response headers  
[`Cache-Control`](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cache-Control)
 and 
[`Expires`](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Expires) 
received from the Upstream service.     |

Review Comment:
   > from the Upstream service
   
   Here? No need as it is not referring to the APISIX Service resource 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to