membphis commented on code in PR #11987:
URL: https://github.com/apache/apisix/pull/11987#discussion_r1980893438
##########
apisix/plugins/openid-connect.lua:
##########
@@ -89,6 +90,33 @@ local schema = {
type = "string",
default = "apisix",
},
+ claim_validator = {
+ type = "object",
+ properties = {
+ audience = {
+ type = "object",
+ description = "audience claim value to validate",
+ properties = {
+ claim = {
+ type = "string",
+ description = "custom claim name",
+ default = "aud",
+ },
+ required = {
+ type = "boolean",
+ description = "audience claim is required",
+ default = false,
+ },
+ match_with_client_id = {
+ type = "boolean",
+ description = "audience must euqal to or includes
client_id",
+ default = false,
+ }
+ },
+ },
+ },
+ default = {},
Review Comment:
can we remove this default value?
empty table `{}`, it seems a little weird
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
