kayx23 commented on code in PR #11921:
URL: https://github.com/apache/apisix/pull/11921#discussion_r1998279631


##########
docs/en/latest/plugins/loki-logger.md:
##########
@@ -28,92 +28,69 @@ description: This document contains information about the 
Apache APISIX loki-log
 #
 -->
 
+<head>
+  <link rel="canonical" href="https://docs.api7.ai/hub/loki-logger"; />
+</head>
+
 ## Description
 
-The `loki-logger` plugin is used to forward logs to [Grafana 
Loki](https://grafana.com/oss/loki/) for analysis and storage.
+The `loki-logger` Plugin pushes request and response logs in batches to 
[Grafana Loki](https://grafana.com/oss/loki/), via the [Loki HTTP 
API](https://grafana.com/docs/loki/latest/reference/loki-http-api/#loki-http-api)
 `/loki/api/v1/push`. The Plugin also supports the customization of log formats.
 
-When the Plugin is enabled, APISIX will serialize the request context 
information to [Log entries in 
JSON](https://grafana.com/docs/loki/latest/api/#push-log-entries-to-loki) and 
submit it to the batch queue. When the maximum batch size is exceeded, the data 
in the queue is pushed to Grafana Loki. See [batch 
processor](../batch-processor.md) for more details.
+When enabled, the Plugin will serialize the request context information to 
[JSON 
objects](https://grafana.com/docs/loki/latest/api/#push-log-entries-to-loki) 
and add them to the queue, before they are pushed to Loki. See [batch 
processor](../batch-processor.md) for more details.
 
 ## Attributes
 
-| Name | Type | Required | Default | Description |
-|---|---|---|---|---|
-| endpoint_addrs | array[string] | True |  | Loki API base URL, format like 
http://127.0.0.1:3100, supports HTTPS and domain names. If multiple endpoints 
are configured, they will be written randomly. |
-| endpoint_uri | string | False | /loki/api/v1/push | If you are using a log 
collection service that is compatible with the Loki Push API, you can use this 
configuration item to customize the API path. |
-| tenant_id | string | False | fake | Loki tenant ID. According to Loki's 
[multi-tenancy 
documentation](https://grafana.com/docs/loki/latest/operations/multi-tenancy/#multi-tenancy),
 its default value is set to the default value `fake` under single-tenancy. |
-| log_labels | object | False | {job = "apisix"} | Loki log label. [APISIX 
variables](../apisix-variable.md) and [Nginx 
variables](http://nginx.org/en/docs/varindex.html) can be used by prefixing the 
string with `$`, both individual and combined, such as `$host` or 
`$remote_addr:$remote_port`. |
-| ssl_verify        | boolean       | False    | true | When set to `true`, 
verifies the SSL certificate. |
-| timeout           | integer       | False    | 3000ms | Timeout for the Loki 
service HTTP call. Range from 1 to 60,000ms.  |
-| keepalive         | boolean       | False    | true | When set to `true`, 
keeps the connection alive for multiple requests. |
-| keepalive_timeout | integer       | False    | 60000ms | Idle time after 
which the connection is closed. Range greater than or equal than 1000ms.  |
-| keepalive_pool    | integer       | False    | 5       | Connection pool 
limit. Range greater than or equal than 1. |
-| log_format | object | False    |          | Log format declared as key value 
pairs in JSON format. Values only support strings. [APISIX 
variables](../apisix-variable.md) and [Nginx 
variables](http://nginx.org/en/docs/varindex.html) can be used by prefixing the 
string with `$`. |
-| include_req_body       | boolean | False    | false | When set to `true` 
includes the request body in the log. If the request body is too big to be kept 
in the memory, it can't be logged due to Nginx's limitations. |
-| include_req_body_expr  | array   | False    |  | Filter for when the 
`include_req_body` attribute is set to `true`. Request body is only logged when 
the expression set here evaluates to `true`. See 
[lua-resty-expr](https://github.com/api7/lua-resty-expr) for more. |
-| include_resp_body      | boolean | False    | false | When set to `true` 
includes the response body in the log. |
-| include_resp_body_expr | array   | False    |  | Filter for when the 
`include_resp_body` attribute is set to `true`. Response body is only logged 
when the expression set here evaluates to `true`. See 
[lua-resty-expr](https://github.com/api7/lua-resty-expr) for more. |
-
-This plugin supports using batch processors to aggregate and process entries 
(logs/data) in a batch. This avoids the need for frequently submitting the 
data. The batch processor submits data every `5` seconds or when the data in 
the queue reaches `1000`. See [Batch 
Processor](../batch-processor.md#configuration) for more information or setting 
your custom configuration.
-
-### Example of default log format
+| Name | Type | Required | Default | Valid values | Description |
+|---|---|---|---|---|---|
+| endpoint_addrs | array[string] | True |  | | Loki API base URLs, such as 
`http://127.0.0.1:3100`. If multiple endpoints are configured, the log will be 
pushed to a randomly determined endpoint from the list. |
+| endpoint_uri | string | False | /loki/api/v1/push | | URI path to the Loki 
ingest endpoint. |
+| tenant_id | string | False | fake | | Loki tenant ID. According to Loki's 
[multi-tenancy 
documentation](https://grafana.com/docs/loki/latest/operations/multi-tenancy/#multi-tenancy),
 the default value is set to `fake` under single-tenancy. |
+| log_labels | object | False | {job = "apisix"} | | Loki log label. Support 
[Nginx variables](https://nginx.org/en/docs/varindex.html) and constant strings 
in values. Variables should be prefixed with a `$` sign. For example, the label 
can be `{"origin" = "apisix"}` or `{"origin" = "$remote_addr"}`. |
+| ssl_verify        | boolean       | False    | true | | If true, verify 
Loki's SSL certificates. |
+| timeout           | integer       | False    | 3000 | [1, 60000] | Timeout 
for the Loki service HTTP call in milliseconds.  |
+| keepalive         | boolean       | False    | true |  | If true, keep the 
connection alive for multiple requests. |
+| keepalive_timeout | integer       | False    | 60000 | >=1000 | Keepalive 
timeout in milliseconds.  |
+| keepalive_pool    | integer       | False    | 5       | >=1 | Maximum 
number of connections in the connection pool.  |
+| log_format | object | False    |          | | Custom log format in key-value 
pairs in JSON format. Support [APISIX variables](../apisix-variable.md) and 
[Nginx variables](http://nginx.org/en/docs/varindex.html) in values. |
+| name | string | False    | loki-logger | | Unique identifier of the Plugin 
for the batch processor. If you use [Prometheus](./prometheus.md) to monitor 
APISIX metrics, the name is exported in `apisix_batch_process_entries`. |
+| include_req_body       | boolean | False    | false | | If true, include the 
request body in the log. Note that if the request body is too big to be kept in 
the memory, it can not be logged due to NGINX's limitations. |
+| include_req_body_expr  | array[array]   | False    |  | | An array of one or 
more conditions in the form of 
[lua-resty-expr](https://github.com/api7/lua-resty-expr). Used when the 
`include_req_body` is true. Request body would only be logged when the 
expressions configured here evaluate to true. |
+| include_resp_body      | boolean | False    | false | | If true, include the 
response body in the log.  |
+| include_resp_body_expr | array[array]   | False    |  | | An array of one or 
more conditions in the form of 
[lua-resty-expr](https://github.com/api7/lua-resty-expr). Used when the 
`include_resp_body` is true. Response body would only be logged when the 
expressions configured here evaluate to true. |

Review Comment:
   this link is right



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to