liuxiran commented on pull request #2440: URL: https://github.com/apache/apisix/pull/2440#issuecomment-710756225
> hi please see here apache/apisix-dashboard#495 so you means apisix should not return disable filed until get request when FE needed? @juzhiyuan it seems that when the schema of the plugin does not have a `properties` property in the first level of the json schema, the interface returns the data with `disable` field. related code: https://github.com/membphis/apisix/blob/133b52ec78665b7292af62bab6af6bf981363a42/apisix/plugin.lua#L81 which doesn't seem reasonable, especially after json schema changed from draft5 to draft7. in json schema draft7, the `oneof` `anyof` and `allof` type of schema e.g the schema in pr https://github.com/apache/apisix/pull/2440,whice does not contain `properties` in first level cc @Jaycean the https://github.com/apache/apisix/issues/2439 may also have something to do with it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
