nic-6443 commented on code in PR #12086: URL: https://github.com/apache/apisix/pull/12086#discussion_r2022047346
########## apisix/init.lua: ########## @@ -550,6 +550,12 @@ function _M.handle_upstream(api_ctx, route, enable_websocket) set_upstream_headers(api_ctx, server) + -- lua proxy the request to upstream + if api_ctx.lua_proxy_upstream then Review Comment: I thought about the naming of the existing variables `bypass_nginx_upstream` and `lua_proxy_upstream`, and felt that their meanings are unclear. I think we can design them as two: * `bypass_nginx_upstream` to indicate bypassing nginx's upstream module * `bypass_balancer` to indicate bypassing the existing balancer logic cc @membphis -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org