Baoyuantop commented on PR #12100:
URL: https://github.com/apache/apisix/pull/12100#issuecomment-2857169341

   Hi @alibabakhanlu12, after actual manual testing, I found some problems. I 
used the environment in [apisix-docker 
](https://github.com/apache/apisix-docker/blob/master/example/docker-compose.yml)to
 verify this file and found that the original json file can work properly in 
subsequent versions(8.x - 12.x). After replacing the new json file, it also 
works, but some charts are missing units and it seems not as easy to understand 
as the old one. I feel that this change is unnecessary. What do you think?
   
   |old|new|
   |-----|-----|
   |<img width="1508" alt="Image" 
src="https://github.com/user-attachments/assets/d55128d6-8ddd-43a6-865d-a51f9572085e";
 />|<img width="1510" alt="Image2" 
src="https://github.com/user-attachments/assets/f4d927c2-4244-47a9-920c-e71f42ba1603";
 />|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to