Copilot commented on code in PR #3020:
URL: https://github.com/apache/apisix-dashboard/pull/3020#discussion_r2077366493
##########
src/routes/plugin_configs/add.tsx:
##########
@@ -0,0 +1,72 @@
+import { createFileRoute, useRouter } from '@tanstack/react-router';
+import { useTranslation } from 'react-i18next';
+import { useMutation } from '@tanstack/react-query';
+import PageHeader from '@/components/page/PageHeader';
+import { FormProvider, useForm } from 'react-hook-form';
+import { zodResolver } from '@hookform/resolvers/zod';
+import { FormSubmitBtn } from '@/components/form/Btn';
+import { FormTOCBox } from '@/components/form-slice/FormSection';
+import { notifications } from '@mantine/notifications';
+import { pipeProduce } from '@/utils/producer';
+import { FormPartPluginConfig } from
'@/components/form-slice/FormPartPluginConfig';
+import { APISIX } from '@/types/schema/apisix';
+import { putPluginConfigReq } from '@/apis/plugin_configs';
+import { nanoid } from 'nanoid';
+
+const PluginConfigAddForm = () => {
+ const { t } = useTranslation();
+ const router = useRouter();
+
+ const putPluginConfig = useMutation({
Review Comment:
Consider adding an onError handler for the mutation to gracefully manage
errors during the add operation.
##########
src/routes/plugin_configs/detail.$id.tsx:
##########
@@ -0,0 +1,118 @@
+import { createFileRoute, useParams } from '@tanstack/react-router';
+import { useTranslation } from 'react-i18next';
+import { useMutation, useSuspenseQuery } from '@tanstack/react-query';
+import PageHeader from '@/components/page/PageHeader';
+import { FormProvider, useForm } from 'react-hook-form';
+import { zodResolver } from '@hookform/resolvers/zod';
+import { FormSubmitBtn } from '@/components/form/Btn';
+import { notifications } from '@mantine/notifications';
+import { FormTOCBox } from '@/components/form-slice/FormSection';
+import { Skeleton, Button, Group } from '@mantine/core';
+import { useBoolean } from 'react-use';
+import { useEffect } from 'react';
+import { APISIX } from '@/types/schema/apisix';
+import {
+ getPluginConfigQueryOptions,
+ putPluginConfigReq,
+} from '@/apis/plugin_configs';
+import { FormPartPluginConfig } from
'@/components/form-slice/FormPartPluginConfig';
+import { pipeProduce } from '@/utils/producer';
+
+type Props = {
+ id: string;
+ readOnly: boolean;
+ setReadOnly: (v: boolean) => void;
+};
+
+const PluginConfigDetailForm = (props: Props) => {
+ const { id, readOnly, setReadOnly } = props;
+ const { t } = useTranslation();
+
+ const pluginConfigQuery = useSuspenseQuery(getPluginConfigQueryOptions(id));
+ const { data } = pluginConfigQuery;
+ const initialValue = data.value;
+
+ const putPluginConfig = useMutation({
Review Comment:
Add an onError handler for the putPluginConfig mutation to handle failure
cases and provide user feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
