bzp2010 commented on code in PR #822:
URL: https://github.com/apache/apisix-helm-chart/pull/822#discussion_r2078852465
##########
charts/apisix/values.yaml:
##########
@@ -440,14 +440,20 @@ apisix:
stream: |
- # -- Add custom
[lua_shared_dict](https://github.com/openresty/lua-nginx-module#toc88) settings,
+ # -- Add custom
[lua_shared_dict](https://github.com/openresty/lua-nginx-module?tab=readme-ov-file#lua_shared_dict)
settings,
# click
[here](https://github.com/apache/apisix-helm-chart/blob/master/charts/apisix/values.yaml#L27-L30)
to learn the format of a shared dict
customLuaSharedDicts: []
# - name: foo
# size: 10k
# - name: bar
# size: 1m
+ # -- Override default
[lua_shared_dict](https://github.com/apache/apisix/blob/master/conf/config.yaml.example#L250-L276)
settings,
+ # click
[here](https://github.com/apache/apisix-helm-chart/blob/master/charts/apisix/values.yaml#L27-L30)
to learn the format of a shared dict
+ luaSharedDicts: []
+ # - name: prometheus-metrics
+ # size: 20m
Review Comment:
This example is inappropriate, prometheus is defined using the special
command for `meta { lua_shared_dict }`, which cannot be overridden by `http {
lua_shared_dict }`, but it does override other dict values, such as those used
by limit-count.
ref:
https://github.com/apache/apisix/blob/master/conf/config.yaml.example#L165-L168
This is a special case for creating shared memory between the HTTP subsystem
and the stream subsystem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
