bzp2010 commented on code in PR #3028: URL: https://github.com/apache/apisix-dashboard/pull/3028#discussion_r2080858435
########## docs/en/latest/config.json: ########## Review Comment: Documentation should be deleted and we will no longer provide a separate documentation build for this project, but should be added to the APISIX project if needed. Since we will no longer be doing releases on the current project, the mechanism in apisix-website that extracts documents based on a specific tag format will no longer work on this project. ########## docs/en/latest/config.json: ########## Review Comment: If you need to add some documentation that is not needed in APISIX but only in this repository, you can drop the existing i18n structure and use the traditional DEVELOP.md or DEVELOPMENT.md. A multi-language version is also available, we can discuss it later. ########## README.md: ########## @@ -1,54 +1,30 @@ -# React + TypeScript + Vite - -This template provides a minimal setup to get React working in Vite with HMR and some ESLint rules. - -Currently, two official plugins are available: - -- [@vitejs/plugin-react](https://github.com/vitejs/vite-plugin-react/blob/main/packages/plugin-react) uses [Babel](https://babeljs.io/) for Fast Refresh -- [@vitejs/plugin-react-swc](https://github.com/vitejs/vite-plugin-react/blob/main/packages/plugin-react-swc) uses [SWC](https://swc.rs/) for Fast Refresh - -## Expanding the ESLint configuration - -If you are developing a production application, we recommend updating the configuration to enable type-aware lint rules: - -```js -export default tseslint.config({ - extends: [ - // Remove ...tseslint.configs.recommended and replace with this - ...tseslint.configs.recommendedTypeChecked, - // Alternatively, use this for stricter rules - ...tseslint.configs.strictTypeChecked, - // Optionally, add this for stylistic rules - ...tseslint.configs.stylisticTypeChecked, - ], - languageOptions: { - // other options... - parserOptions: { - project: ['./tsconfig.node.json', './tsconfig.app.json'], - tsconfigRootDir: import.meta.dirname, - }, - }, -}) -``` - -You can also install [eslint-plugin-react-x](https://github.com/Rel1cx/eslint-react/tree/main/packages/plugins/eslint-plugin-react-x) and [eslint-plugin-react-dom](https://github.com/Rel1cx/eslint-react/tree/main/packages/plugins/eslint-plugin-react-dom) for React-specific lint rules: - -```js -// eslint.config.js -import reactX from 'eslint-plugin-react-x' -import reactDom from 'eslint-plugin-react-dom' - -export default tseslint.config({ - plugins: { - // Add the react-x and react-dom plugins - 'react-x': reactX, - 'react-dom': reactDom, - }, - rules: { - // other rules... - // Enable its recommended typescript rules - ...reactX.configs['recommended-typescript'].rules, - ...reactDom.configs.recommended.rules, - }, -}) -``` +# Apache APISIX Dashboard + +[](https://github.com/apache/apisix-dashboard/blob/master/LICENSE) +[](https://apisix.apache.org/slack) + +<p align="center"> + <a href="https://apisix.apache.org/";>Website</a> • + <a href="https://github.com/apache/apisix/tree/master/docs";>Docs</a> • + <a href="https://twitter.com/apacheapisix";>Twitter</a> +</p> + +- The master version should be used with Apache APISIX master version. Review Comment: ```suggestion - The master version should be used with Apache APISIX master version. - The project will not be released independently but will use a fixed git tag for each APISIX release. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
