AlinsRan commented on code in PR #12256:
URL: https://github.com/apache/apisix/pull/12256#discussion_r2114928453
##########
apisix/schema_def.lua:
##########
@@ -729,7 +729,18 @@ _M.credential = {
type = "object",
properties = {
-- metadata
- id = id_schema,
+ id = {
+ oneOf = {
+ id_schema,
+ -- id: "${consumer_name}/credentials/${credential_id}" from
standalone mode
+ {
+ type = "string",
+ minLength = 15,
+ maxLength = 128,
+ pattern = [[^[a-zA-Z0-9]+/credentials/[a-zA-Z0-9]+$]],
+ }
+ }
Review Comment:
Expectations are global changes, not just affecting a specific module, and
deep copies are meaningless.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
