bzp2010 commented on code in PR #12276:
URL: https://github.com/apache/apisix/pull/12276#discussion_r2122756649


##########
conf/config.yaml.example:
##########
@@ -674,6 +674,7 @@ deployment:                    # Deployment configurations
       #   role: viewer
 
     enable_admin_cors: true       # Enable Admin API CORS response header 
`Access-Control-Allow-Origin`.
+    enable_admin_ui: true         # Enable embedded APISIX Dashboard UI.

Review Comment:
   On the data plane, the Admin API won't actually start at all.
   Since the ui enforces the use of the Admin API port (to minimize problems 
with CORS), it is implicit that if the Admin API is not enabled, the ui will 
not be enabled.
   
   So the answer to that question is that if the Admin API is not enabled (e.g. 
by turning it off on traditional, or by using data plane mode), the config item 
will have no effect. That is, whatever it is set to, the ui will not be exposed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to