[GitHub] [apisix] LY-GO commented on pull request #2465: bugfix(limit-conn): always save the data of the limit object, and release it in log phase.

[GitBox]

LY-GO commented on pull request #2465:
URL: https://github.com/apache/apisix/pull/2465#issuecomment-712767911


   > > > > @LY-GO you can make a try with this PR
   > > > > 2.i modify the code of limit-conn according to your repair.But the 
response code is 500
   > > > > 
![code](https://user-images.githubusercontent.com/67543312/96450457-d37c0e00-1248-11eb-810b-98de860c2669.png)
   > 
   > > @LY-GO you can make a try with this PR
   > 
   > I test the plugin,i find it don't work;now every request can success,even 
if number of request over concurrency limit.I just copy your code,overwrite a 
new plugin and reload the plugin
   
   two suggesstions:
   1.When you use limit-conn plugin,you must set default_conn_delay > 0, 
otherwise you will find assertion failed.
   2.When you test limit-conn plugin,your upstream must set sleep time.Because 
concurrency is required at the same time .


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org