swapnil-omni commented on code in PR #822:
URL: https://github.com/apache/apisix-helm-chart/pull/822#discussion_r2137165168
##########
charts/apisix/templates/configmap.yaml:
##########
Review Comment:
This does not work.
The nginx config is like this
```
lua_shared_dict:
prometheus-metrics: 20m
```
This created config like this
```
lua_shared_dict:
- prometheus-metrics: 20m
```
so this should be
```
{{- range $dict := .Values.apisix.nginx.luaSharedDicts }}
{{ $dict.name }}: {{ $dict.size }}
```
https://github.com/apache/apisix/blob/master/conf/config.yaml.example#L250-L276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
