bzp2010 commented on code in PR #12304:
URL: https://github.com/apache/apisix/pull/12304#discussion_r2139170580
##########
apisix/discovery/consul/init.lua:
##########
@@ -516,6 +516,10 @@ function _M.connect(premature, consul_server, retry_delay)
end
local svc_address, svc_port = node.Service.Address,
node.Service.Port
+ -- Handle nil or 0 port case - default to 80 for HTTP
services
+ if not svc_port or svc_port == 0 then
Review Comment:
TCP and UDP ports can be 0.
Although it stands for "special use", it should be clearly distinguished
from port is null. If this value is explicitly configured as 0, then we should
accept it and not change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
