SkyeYoung commented on PR #3111: URL: https://github.com/apache/apisix-dashboard/pull/3111#issuecomment-2965365802
> I understand why it's written this way (it could be optional), but the name `WithServiceIdFilter` makes me think it must contain the `ServiceId`. No better suggestions. Let's keep pushing forward, not being blocked by a better type name -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
