Copilot commented on code in PR #3113:
URL: https://github.com/apache/apisix-dashboard/pull/3113#discussion_r2144147232
##########
src/apis/stream_routes.ts:
##########
@@ -59,3 +63,21 @@ export const postStreamRouteReq = (
API_STREAM_ROUTES,
data
);
+
+export const deleteAllStreamRoutes = async (req: AxiosInstance) => {
Review Comment:
[nitpick] The loop computing pages based on `PAGE_SIZE_MIN` and
`PAGE_SIZE_MAX` is a bit complex; consider simplifying to a `while` loop that
fetches and deletes until the list is empty, reducing index calculations and
improving readability.
##########
src/components/form-slice/FormPartStreamRoute/index.tsx:
##########
@@ -81,12 +81,14 @@ const FormSectionStreamRouteProtocol = () => {
control={control}
name="protocol.conf"
label={t('form.streamRoutes.protocol.conf')}
+ toObject
Review Comment:
[nitpick] For consistency, explicitly pass `objValue={{}}` when using
`toObject` on the `protocol.conf` field, making the default value clear and
symmetric with the `logger` field.
```suggestion
toObject
objValue={{}}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
