membphis commented on a change in pull request #2481:
URL: https://github.com/apache/apisix/pull/2481#discussion_r509013222



##########
File path: Makefile
##########
@@ -24,6 +24,10 @@ UNAME ?= $(shell uname)
 OR_EXEC ?= $(shell which openresty)
 LUAROCKS_VER ?= $(shell luarocks --version | grep -E -o  "luarocks [0-9]+.")
 
+SHELL := /bin/bash -o pipefail

Review comment:
       seems that this line is not necessary. can we delete it?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to