nic-6443 commented on code in PR #12366:
URL: https://github.com/apache/apisix/pull/12366#discussion_r2163111074
##########
apisix/init.lua:
##########
@@ -1022,25 +1046,6 @@ function _M.http_control()
end
-function _M.stream_ssl_phase()
- local ngx_ctx = ngx.ctx
- local api_ctx = core.tablepool.fetch("api_ctx", 0, 32)
- ngx_ctx.api_ctx = api_ctx
-
- local ok, err = router.router_ssl.match_and_set(api_ctx)
-
- core.tablepool.release("api_ctx", api_ctx)
- ngx_ctx.api_ctx = nil
-
- if not ok then
- if err then
- core.log.error("failed to fetch ssl config: ", err)
- end
- ngx_exit(-1)
- end
-end
Review Comment:
Yes, previously the stream subsystem did not use the `client_hello_by_lua`
phase. But in this fix, it is necessary to use this phase.
After comparing the code of the http and stream subsystems, I confirmed that
the code for both `client_hello_by_lua` and `certificate_by_lua` phases can be
reused in these two subsystems, making it unnecessary to maintain a separate
`stream_ssl_phase`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
