ShiningRush commented on a change in pull request #581:
URL: https://github.com/apache/apisix-dashboard/pull/581#discussion_r509257959



##########
File path: README.md
##########
@@ -49,35 +49,25 @@ $ cd apisix-dashboard
 
 The `manager-api` is used to provide APIs for Dashboard, just like a bridge 
between the Apache APISIX and the Dashboard. Here are the steps to build it 
manually:
 
-1. We need `MySQL/Golang` to be preinstalled.
+1. We need `Go` 1.13+, `ETCD` 3.4+ and `Lua` 5.1+ to be preinstalled.
 
-```sh
-# e.g Initialization for MySQL, please use a more secure Password instead of 
123456.
-$ mysql –uroot –p123456
-> source ./api/script/db/schema.sql
-```
-
-2. Start the Apache APISIX.
+2. Check environment variables
 
-[Please follow this 
guide](https://github.com/apache/apisix#configure-and-installation)
-
-3. Check environment variables
+- enable Go MODULE
+```
+go env -w GO111MODULE=on
+```
 
-According to your local deployment environment, check the environment 
variables in `./api/run/run.sh`, modify the environment variables if needed.
+- According to your local deployment environment, check the environment 
variables in `./api/run.sh`, modify the environment variables if needed.
 
-For most users in China, we could use [Goproxy](https://goproxy.cn/) to speed 
up downloading modules.
+- For most users in China, we could use [Goproxy](https://goproxy.cn/) to 
speed up downloading modules.

Review comment:
       We can add a concrete command, such as 
   ```
   export GOPROXY=https://goproxy.cn,direct
   ```

##########
File path: README.md
##########
@@ -49,35 +49,25 @@ $ cd apisix-dashboard
 
 The `manager-api` is used to provide APIs for Dashboard, just like a bridge 
between the Apache APISIX and the Dashboard. Here are the steps to build it 
manually:
 
-1. We need `MySQL/Golang` to be preinstalled.
+1. We need `Go` 1.13+, `ETCD` 3.4+ and `Lua` 5.1+ to be preinstalled.

Review comment:
       Maybe for build jsonschema?
   But I think we can build it in development phase, no need build it at 
installing




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to