Revolyssup commented on code in PR #12405:
URL: https://github.com/apache/apisix/pull/12405#discussion_r2203845542
##########
apisix/plugins/forward-auth.lua:
##########
@@ -102,6 +119,21 @@ function _M.access(conf, ctx)
auth_headers["Content-Encoding"] = core.request.header(ctx,
"content-encoding")
end
+ if conf.extra_headers then
+ for header, value in pairs(conf.extra_headers) do
+ if type(value) == "number" then
+ value = tostring(value)
+ end
+ local resolve_value, err, n_resolved =
core.utils.resolve_var(value, ctx.var)
+ if not err and n_resolved > 0 then
+ auth_headers[header] = resolve_value
+ end
Review Comment:
When the value doesn't have $, the err will be nil and it will still be
added to auth_headers.
This error and skip happens when value has $(is some variable) but couldn't
be resolved. In that case, there is no point in adding it to auth headers as
the value is obviously not the intended value to be added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
