nic-6443 commented on code in PR #12424:
URL: https://github.com/apache/apisix/pull/12424#discussion_r2204317597
##########
apisix/admin/consumers.lua:
##########
@@ -60,6 +60,11 @@ return resource.new({
name = "consumers",
kind = "consumer",
schema = core.schema.consumer,
- checker = check_conf,
+ checker = function (username, conf, need_username, schema)
+ return check_conf(username, conf, need_username, schema, false)
+ end,
+ standalone_checker = function (username, conf, need_username, schema)
+ return check_conf(username, conf, need_username, schema, true)
+ end,
Review Comment:
I feel that providing two separate `checkers` makes it easy for developers
to overlook the `skip_etcd_check` parameter when adding a new resource or
adding check code to an existing resource.
It would be better to add the `skip_etcd_check` parameter to the
`check_conf` function of all resources, even if this parameter is not used in
that resource like `upstreams`、`ssl` etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
