Copilot commented on code in PR #12391:
URL: https://github.com/apache/apisix/pull/12391#discussion_r2218734644
##########
apisix/plugins/grpc-transcode/response.lua:
##########
@@ -23,6 +23,44 @@ local string = string
local ngx_decode_base64 = ngx.decode_base64
local ipairs = ipairs
local pcall = pcall
+local type = type
+local pairs = pairs
+local setmetatable = setmetatable
+
+pb.option "decode_default_array"
+local repeated_label = 3
Review Comment:
The magic number '3' should be replaced with a named constant or documented
with a comment explaining that this represents the protobuf repeated field
label value.
```suggestion
-- Protobuf repeated field label value
local PROTOBUF_REPEATED_LABEL = 3
local repeated_label = PROTOBUF_REPEATED_LABEL
```
##########
apisix/plugins/grpc-transcode/response.lua:
##########
@@ -23,6 +23,44 @@ local string = string
local ngx_decode_base64 = ngx.decode_base64
local ipairs = ipairs
local pcall = pcall
+local type = type
+local pairs = pairs
+local setmetatable = setmetatable
+
+pb.option "decode_default_array"
+local repeated_label = 3
+
+local function fetch_proto_array_names(proto_obj)
+ local names = {}
+ if type(proto_obj) == "table" then
+ for k,v in pairs(proto_obj) do
+ if type(v) == "table" then
+ local sub_names = fetch_proto_array_names(v)
+ for sub_name,_ in pairs(sub_names) do
+ names[sub_name] = 1
+ end
+ end
+ end
+ if proto_obj["label"] == repeated_label then
+ names[proto_obj["name"]] = 1
+ end
+ end
+ return names
+end
+
+local function set_default_array(tab, array_names)
+ if type(tab) ~= "table" then
+ return false
Review Comment:
The function returns 'false' for non-table inputs but this return value is
never used by callers. Consider removing the return statement or making the
function return void.
```suggestion
return
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
