Baoyuantop commented on code in PR #11654:
URL: https://github.com/apache/apisix/pull/11654#discussion_r2220873336


##########
t/kubernetes/discovery/kubernetes3.t:
##########
@@ -165,19 +165,19 @@ _EOC_
 
                     if op.op == "replace_endpointslices" then
                         method = "PATCH"
-                        path = "/apis/discovery.k8s.io/namespaces/" .. 
op.namespace .. "/endpointslices/" .. op.name
+                        path = "/apis/discovery.k8s.io/v1/namespaces/" .. 
op.namespace .. "/endpointslices/" .. op.name

Review Comment:
   Can you explain why these changes were made?



##########
docs/zh/latest/discovery/kubernetes.md:
##########
@@ -300,7 +300,7 @@ A: Kubernetes 服务发现只使用特权进程监听 Kubernetes Endpoints,然
 
 **Q: 
[_ServiceAccount_](https://kubernetes.io/docs/tasks/configure-pod-container/configure-service-account/)
 需要的权限有哪些?**
 
-A: 
[_ServiceAccount_](https://kubernetes.io/docs/tasks/configure-pod-container/configure-service-account/)
 需要集群级 [ get,list,watch ] endpoints 资源的的权限,其声明式定义如下:
+A: 
[_ServiceAccount_](https://kubernetes.io/docs/tasks/configure-pod-container/configure-service-account/)
 需要集群级 [ get,list,watch ] endpoints and endpointslices 资源的的权限,其声明式定义如下:

Review Comment:
   ```suggestion
   A: 
[_ServiceAccount_](https://kubernetes.io/docs/tasks/configure-pod-container/configure-service-account/)
 需要集群级 [ get,list,watch ] endpoints 和 endpointslices 资源的的权限,其声明式定义如下:
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to