Revolyssup commented on code in PR #12435:
URL: https://github.com/apache/apisix/pull/12435#discussion_r2227315963


##########
docs/en/latest/plugins/forward-auth.md:
##########


Review Comment:
   There are some issues in the existing doc here llke:
   1. Addition of ` -H "Content-Type: application/json" ` in example without 
which the post_arg wont be passed and users wont the result mentioned in doc.
   2. Since we claim to pass the header, it is good to modify the serverless 
function in doc that actually checks the forwarded header. So that users can be 
assured that headers are passed. Previous to the current change, only it's 
existence is checked and value not verified.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to