undying commented on code in PR #12187:
URL: https://github.com/apache/apisix/pull/12187#discussion_r2247744447
##########
apisix/upstream.lua:
##########
@@ -305,7 +305,12 @@ function _M.set_by_route(route, api_ctx)
return 503, err
end
- local new_nodes, err = dis.nodes(up_conf.service_name,
up_conf.discovery_args)
+ local service_name, err = core.utils.resolve_var(up_conf.service_name,
api_ctx.var)
+ if not service_name or service_name == "" then
+ return 503, "resolve_var resolves to empty string: " .. (err or
"nil")
+ end
+
+ local new_nodes, err = dis.nodes(service_name, up_conf.discovery_args)
if not new_nodes then
return HTTP_CODE_UPSTREAM_UNAVAILABLE, "no valid upstream node: "
.. (err or "nil")
Review Comment:
I added logging service_name. This format is ok?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
