SkyeYoung commented on code in PR #12448: URL: https://github.com/apache/apisix/pull/12448#discussion_r2250356005
########## t/discovery/consul_dump.t: ########## @@ -95,7 +95,7 @@ discovery: --- request GET /t --- response_body -{"service_a":[{"host":"127.0.0.1","port":30511,"weight":1}],"service_b":[{"host":"127.0.0.1","port":8002,"weight":1}]} +{"service_a":[{"host":"127.0.0.1","metadata":{"service_a_version":"4.0"},"port":30511,"weight":1}],"service_b":[{"host":"127.0.0.1","metadata":{"service_b_version":"4.1"},"port":8002,"weight":1}]} Review Comment: @jizhuozhi My question is, if this is added, do we now lack a test case for the situation where there is "no metadata"? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org