Revolyssup commented on code in PR #12509:
URL: https://github.com/apache/apisix/pull/12509#discussion_r2268625340


##########
apisix/plugin.lua:
##########
@@ -1234,6 +1236,26 @@ function _M.run_plugin(phase, plugins, api_ctx)
     return api_ctx, plugin_run
 end
 
+function _M.set_plugins_meta_parent(plugins, parent)
+    if not plugins then
+        return
+    end
+    for _, plugin_conf in pairs(plugins) do
+        if not plugin_conf._meta then
+            plugin_conf._meta = {}
+        end
+        if not plugin_conf._meta.parent then
+            local mt_table = getmetatable(plugin_conf._meta)
+            if mt_table then
+                mt_table.parent = parent

Review Comment:
   the healthcheck_manager module is tied only to manage the checkers on the 
upstream configuration. I don't know if we can use that mechanism here because 
here we are creating custom healthchecker using the checks configuration in the 
plugin configuration.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to