nic-6443 commented on code in PR #12514:
URL: https://github.com/apache/apisix/pull/12514#discussion_r2275245053


##########
t/xrpc/pingpong.t:
##########
@@ -154,7 +154,7 @@ pp\x01\x00\x00\x00\x00\x00\x00\x00"
 "pp\x02\x00\x00\x00\x00\x00\x00\x03ABC" x 3
 --- log_level: debug
 --- no_error_log
-stream lua tcp socket set keepalive
+stream lua tcp socket keepalive create connection pool for key "127.0.0.1:1995"

Review Comment:
   Because the current PR send a `readdir` request before the `watch` request, 
it causes the etcd client to trigger keepalive logs, making the old assertion 
fail. Therefore, this assertion is modified to explicitly target keepalive log 
of xrpc upstream to avoid matching etcd's keepalive logs.



##########
t/xrpc/pingpong.t:
##########
@@ -154,7 +154,7 @@ pp\x01\x00\x00\x00\x00\x00\x00\x00"
 "pp\x02\x00\x00\x00\x00\x00\x00\x03ABC" x 3
 --- log_level: debug
 --- no_error_log
-stream lua tcp socket set keepalive
+stream lua tcp socket keepalive create connection pool for key "127.0.0.1:1995"

Review Comment:
   Because the current PR send a `readdir` request before the `watch` request, 
it causes the etcd client to trigger keepalive logs, making the old assertion 
fail. Therefore, this assertion is modified to explicitly target keepalive log 
of xrpc upstream to avoid matching etcd client's keepalive logs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to