jizhuozhi commented on code in PR #12448:
URL: https://github.com/apache/apisix/pull/12448#discussion_r2281455473


##########
t/discovery/consul.t:
##########
@@ -781,3 +781,71 @@ location /sleep {
     qr//
 ]
 --- ignore_error_log
+
+
+
+=== TEST 16: test metadata_match with consul discovery

Review Comment:
   Yes, after adding `- v4` and removing `- v2`, the request should only be 
routed to those marked as `v3` or `v4`. 
   
   It seems to be equivalent to the current test case, as `discovery_args` is 
atomic updated, however I will add new case with adding `- v4` and removing `- 
v2` means the request should only be routed to those marked as `v3` or `v4` :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to