AlinsRan commented on code in PR #2518:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/2518#discussion_r2289971104


##########
internal/controller/apisixroute_controller.go:
##########
@@ -321,6 +358,12 @@ func (r *ApisixRouteReconciler) validateBackends(ctx 
context.Context, tc *provid
                        }
                } else {
                        tc.Upstreams[serviceNN] = &au
+                       if err = r.processExternalNodes(ctx, tc, au); err != 
nil {

Review Comment:
   The backend uses Kubernetes services for service discovery, which should not 
allow custom endpoints. I don't think this needs to be handled.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to