bzp2010 commented on code in PR #3178:
URL: https://github.com/apache/apisix-dashboard/pull/3178#discussion_r2291055183
##########
e2e/server/nginx.conf:
##########
@@ -19,13 +19,13 @@ server {
listen 6174;
location /ui {
- rewrite ^/ui$ /ui/ permanent;
+ rewrite ^/ui$ /ui/ permanent;
}
location /ui/ {
alias /usr/share/nginx/html/;
- index index.html;
- try_files $uri $uri/ /ui/index.html;
+ gzip_static always;
+ error_page 404 /ui/index.html;
Review Comment:
If `error_page` meets our needs, we can use it, even in APISIX. Just add
some comments.
Configuring `try_files` requires nginx expert, while `error_page` seems more
straightforward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
