SkyeYoung commented on code in PR #12539:
URL: https://github.com/apache/apisix/pull/12539#discussion_r2292455045
##########
apisix/plugins/ldap-auth.lua:
##########
@@ -66,23 +67,27 @@ function _M.check_schema(conf, schema_type)
return ok, err
end
-local function extract_auth_header(authorization)
+local function extract_auth_header(auth)
local obj = { username = "", password = "" }
+ -- Check format of Authorization header.
+ local matches, err = ngx_re.split(auth, "\\s+", nil, nil, 2)
- local m, err = ngx.re.match(authorization, "Basic\\s(.+)", "jo")
Review Comment:
The current implementation refers to
https://github.com/apache/apisix/blob/12b0824e23e82ee097dcdd3fa7faafe35dc674c8/apisix/plugins/openid-connect.lua#L393-L407.
But as you said, it is indeed much simpler in terms of syntax.
I may need to try it to determine their performance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
