moonming commented on code in PR #12536:
URL: https://github.com/apache/apisix/pull/12536#discussion_r2296032763
##########
apisix/discovery/kubernetes/schema.lua:
##########
@@ -17,7 +17,8 @@
local host_patterns = {
{ pattern = [[^\${[_A-Za-z]([_A-Za-z0-9]*[_A-Za-z])*}$]] },
- { pattern =
[[^[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*$]] },
+ { pattern = [[^[A-Za-z0-9]([-A-Za-z0-9]*[A-Za-z0-9])?]] ..
Review Comment:
according to
https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#dns-subdomain-names,
we don't need to support uppercase letters
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
