Copilot commented on code in PR #2534:
URL:
https://github.com/apache/apisix-ingress-controller/pull/2534#discussion_r2312793846
##########
internal/provider/apisix/provider.go:
##########
@@ -236,19 +237,29 @@ func (d *apisixProvider) Start(ctx context.Context) error
{
}
ticker := time.NewTicker(d.SyncPeriod)
defer ticker.Stop()
+
+ retrier :=
common.NewRetrier(common.NewExponentialBackoff(1*time.Second, 1000*time.Second))
Review Comment:
The magic numbers for backoff timing (1 second base, 1000 seconds max)
should be extracted as configurable constants or parameters to make the retry
behavior configurable.
##########
internal/provider/common/retrier.go:
##########
@@ -0,0 +1,91 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package common
+
+import (
+ "sync"
+ "time"
+)
+
+type Backoff interface {
+ Next() time.Duration
+ Reset()
+}
+
+type ExponentialBackoff struct {
+ base, max, current time.Duration
+}
+
+func NewExponentialBackoff(base, max time.Duration) *ExponentialBackoff {
+ return &ExponentialBackoff{base: base, max: max, current: base}
+}
+
+func (b *ExponentialBackoff) Next() time.Duration {
+ delay := b.current
+ b.current *= 2
+ if b.current > b.max {
+ b.current = b.max
+ }
+ return delay
+}
+
+func (b *ExponentialBackoff) Reset() {
+ b.current = b.base
+}
+
+type Retrier struct {
+ mu sync.Mutex
+ ch chan struct{}
+ timer *time.Timer
+ backoff Backoff
+}
+
+func NewRetrier(b Backoff) *Retrier {
+ return &Retrier{
+ ch: make(chan struct{}, 1),
+ backoff: b,
+ }
+}
+
+func (r *Retrier) Cancel() {
+ r.mu.Lock()
+ defer r.mu.Unlock()
+
+ if r.timer != nil {
+ r.timer.Stop()
+ r.timer = nil
+ }
+ r.backoff.Reset()
+}
+
+func (r *Retrier) Trigger() {
+ r.mu.Lock()
+ defer r.mu.Unlock()
+
+ delay := r.backoff.Next()
+ r.timer = time.AfterFunc(delay, func() {
+ select {
+ case r.ch <- struct{}{}:
+ default:
+ }
+ })
Review Comment:
The timer creation and channel send operation could race with the Cancel()
method. Consider setting r.timer to nil in the AfterFunc callback after sending
to the channel to prevent potential issues with subsequent Cancel() calls.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
