fekitibi commented on issue #12170: URL: https://github.com/apache/apisix/issues/12170#issuecomment-3242146618
Hi @Baoyuantop , Thanks for all the feedback so far. I won’t have enough time in the near future to continue working on this issue, so please feel free to reassign it. I already tried three approaches: - moving admin_key handling, admin key generation to memory only https://github.com/apache/apisix/pull/12484 - shutting down APISIX when an empty key is detected (I did not create a PR for this but tested locally -> it needed a lot of test rewrites/fixes so I skipped it) - skipping empty admin keys on validation https://github.com/apache/apisix/pull/12535 Earlier feedback might have helped avoid some of the rework, but I still found this a good learning opportunity and appreciated the guidance along the way. I hope to contribute again when I have more time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
