nic-6443 commented on code in PR #12604:
URL: https://github.com/apache/apisix/pull/12604#discussion_r2335290695
##########
apisix/admin/standalone.lua:
##########
@@ -420,6 +430,29 @@ function _M.init_worker()
end
events:register(update_config, EVENT_UPDATE, EVENT_UPDATE)
+ -- due to the event module can not broadcast events between http and
stream subsystems,
+ -- we need to poll the shared dict to keep the config in sync
+ local last_sync_time = ngx_time()
Review Comment:
ref from https://github.com/apache/apisix/issues/12556
> To address this issue and further ensure the reliability of the event
notification mechanism, I believe we should introduce a background timer loop.
This would allow the configuration refresh mechanism to passively take effect
even if event broadcasting fails.
Since we check `METADATA_LAST_MODIFIED` and `last_sync_time` first, this
timer is lightweight. I think we can run it in the HTTP subsystem too, ensuring
config sync even if event broadcasting fails (not only for stream subsystem).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
