AlinsRan commented on code in PR #2551: URL: https://github.com/apache/apisix-ingress-controller/pull/2551#discussion_r2335461109
########## api/v2/shared_types.go: ########## @@ -45,6 +45,11 @@ const ( DefaultWeight = 100 ) +const ( + ResolveGranularityService = "service" + ResolveGranularityEndpoint = "endpoint" +) Review Comment: These two fields are the behavior of CRD. The CRD should not rely on ADC types. I suggest keeping everything. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org