SkyeYoung commented on code in PR #12603:
URL: https://github.com/apache/apisix/pull/12603#discussion_r2347704263
##########
apisix/plugins/request-id.lua:
##########
@@ -51,7 +51,10 @@ local schema = {
default =
"abcdefghijklmnopqrstuvwxyzABCDEFGHIGKLMNOPQRSTUVWXYZ0123456789"
}
},
- default = {}
+ default = {
+ length = 16,
+ char_set =
"abcdefghijklmnopqrstuvwxyzABCDEFGHIGKLMNOPQRSTUVWXYZ0123456789"
+ }
Review Comment:
The tests revealed that this is the only way to properly populate default
values when `range_id` doesn't exist.
The original one should be because it's filled again after writing
`default={}`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
