Revolyssup commented on code in PR #2550: URL: https://github.com/apache/apisix-ingress-controller/pull/2550#discussion_r2349437477
########## internal/manager/server/server.go: ########## @@ -0,0 +1,69 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package server + +import ( + "context" + "net/http" + "time" + + "github.com/apache/apisix-ingress-controller/internal/provider" +) + +type Server struct { + server *http.Server + mux *http.ServeMux +} + +func (s *Server) Start(ctx context.Context) error { + stop := make(chan error, 1) + go func() { + if err := s.server.ListenAndServe(); err != nil && err != http.ErrServerClosed { + stop <- err + } + close(stop) + }() + select { + case <-ctx.Done(): + shutdownCtx, cancel := context.WithTimeout(context.Background(), 5*time.Second) + defer cancel() + return s.server.Shutdown(shutdownCtx) + case err := <-stop: + return err + } +} + +func (s *Server) Register(pathPrefix string, registrant provider.RegisterHandler) { + subMux := http.NewServeMux() + registrant.Register(pathPrefix, subMux) + s.mux.Handle(pathPrefix+"/", http.StripPrefix(pathPrefix, subMux)) + s.mux.HandleFunc(pathPrefix, func(w http.ResponseWriter, r *http.Request) { + http.Redirect(w, r, pathPrefix+"/", http.StatusPermanentRedirect) + }) +} Review Comment: The restart will rebuild the in-memory store which is the data store for this API. Given same set of configuration, theoretically it should go rebuild the same state according to me. Because the data from this in-mem store directly corresponds to data that will be sent to data plane, in case there are inconsistencies on restart this has to be a bug. If there are problems that resolve after restart, then we should note them and debug to find the root cause. The expectation from the system should be such that it produces consistently same state for the same input. And on this expectation of the system we can go with the static config approach. I cannot think of a case where it will be expected from the system to produce different state on reruns. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
