ronething commented on code in PR #2569:
URL:
https://github.com/apache/apisix-ingress-controller/pull/2569#discussion_r2358438864
##########
Makefile:
##########
@@ -268,6 +268,17 @@ ifndef ignore-not-found
ignore-not-found = false
endif
+.PHONY: e2e-ldap
+e2e-ldap:
+ifeq ("$(E2E_FOCUS)", "")
Review Comment:
If we don't use this variable for focusing test case, it will start openldap
every time when we run the test case on local machine. Can we consider putting
`make e2e-ldap` in the `apisix-e2e-test.yaml`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
