nic-6443 commented on code in PR #12603:
URL: https://github.com/apache/apisix/pull/12603#discussion_r2358291043
##########
apisix/admin/resource.lua:
##########
@@ -123,7 +124,12 @@ function _M:check_conf(id, conf, need_id, typ, allow_time)
core.log.info("schema: ", core.json.delay_encode(self.schema))
end
- local ok, err = self.checker(id, conf, need_id, self.schema, {secret_type
= typ})
+ local conf_for_check = tbl_deepcopy(conf)
+ local ok, err = self.checker(id, conf_for_check, need_id, self.schema,
{secret_type = typ})
Review Comment:
I can't think of any issues that require specifying `fillin_default=true` to
troubleshoot, but adding this option doesn't really have any drawbacks either,
making it difficult to decide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
