Revolyssup commented on code in PR #2564:
URL:
https://github.com/apache/apisix-ingress-controller/pull/2564#discussion_r2366935973
##########
internal/provider/apisix/provider.go:
##########
@@ -108,6 +108,9 @@ func (d *apisixProvider) Update(ctx context.Context, tctx
*provider.TranslateCon
case *gatewayv1.HTTPRoute:
result, err = d.translator.TranslateHTTPRoute(tctx,
t.DeepCopy())
resourceTypes = append(resourceTypes, adctypes.TypeService)
+ case *gatewayv1alpha2.TCPRoute:
Review Comment:
When deletion is not explicitly handled then the resourceTypes slice here is
empty and in that case all cache is cleared for that key where is key is
GatewayProxy.
https://github.com/apache/apisix-ingress-controller/blob/7399778b0b261353662d1dff5de012818d7d17c7/internal/adc/cache/store.go#L207
I thought this was intentional because for unhandled resources in delete
function, it says explicitly that all resources will be deleted.
https://github.com/apache/apisix-ingress-controller/blob/7399778b0b261353662d1dff5de012818d7d17c7/internal/provider/apisix/provider.go#L185
Is it not intentional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
