Jaycean commented on pull request #2415:
URL: https://github.com/apache/apisix/pull/2415#issuecomment-715663919


   > @Jaycean I think we can add a checkpoint for confirming if we fetched a 
correct `consumer_name`.
   > 
   > 
https://github.com/apache/apisix/blob/49818548f5510a0789c93519aaedd08c35ae69f8/apisix/plugins/limit-conn.lua#L72
   
   There may be new fields added to the `consumer_name` field in the future, 
the default is `""`, to determine whether the current field is in the optional 
range? If there are new fields, continue to add? Because I think that if the 
wrong field is selected, the plugin is actually unavailable.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to