Copilot commented on code in PR #888:
URL: https://github.com/apache/apisix-helm-chart/pull/888#discussion_r2438186177
##########
charts/apisix-ingress-controller/templates/cluster_role.yaml:
##########
@@ -94,7 +94,6 @@ rules:
- gateway.networking.k8s.io
resources:
- gatewayclasses
Review Comment:
The removal of 'gateways' from this rule while adding it to a separate rule
at line 119 appears to be a reorganization. Ensure this change maintains the
same effective permissions for gateway resources.
##########
charts/apisix-ingress-controller/templates/configmap.yaml:
##########
@@ -38,3 +38,11 @@ data:
type: {{ .Values.config.provider.type | default "apisix" }}
sync_period: {{ .Values.config.provider.syncPeriod | default "1s" }}
init_sync_delay: {{ .Values.config.provider.initSyncDelay | default
"20m" }}
+ {{- if .Values.webhook.enabled }}
+ webhook:
+ enable: true
+ port: {{ .Values.webhook.port }}
+ tls_cert_file: "tls.crt"
+ tls_key_file: "tls.key"
Review Comment:
The TLS certificate and key file names are hardcoded. Consider making these
configurable through values.yaml to allow customization when users provide
their own certificates.
```suggestion
tls_cert_file: {{ .Values.webhook.tlsCertFile | quote | default
"\"tls.crt\"" }}
tls_key_file: {{ .Values.webhook.tlsKeyFile | quote | default
"\"tls.key\"" }}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
